Query all greenwave decision contexts together #4821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note this ironically acts almost as a reversion of #4266 - we're almost back to the code before that change, except now we're passing a list of contexts instead of a single string. |
AdamWill
force-pushed
the
combine-decision-contexts
branch
3 times, most recently
from
8704ba9
to
df96581
Compare
|
I think the integration tests will fail until a greenwave version with the change is marked as production. |
AdamWill
force-pushed
the
combine-decision-contexts
branch
2 times, most recently
from
944b0a4
to
e3f6570
Compare
|
greenwave change is tagged for prod now. I've rebased this, let's see how it goes. |
|
The code looks good and tests are happy now, with the updated greenwave in prod and the fix for poetry installation in Rawhide. |
|
It's arguable whether it needs one, really, as it's barely a user-visible change (the only thing a user will notice is that gating status updates faster). But I can add one, sure... |
AdamWill
force-pushed
the
combine-decision-contexts
branch
from
e3f6570
to
b470aa7
Compare
Since release-engineering/greenwave#95 , greenwave allows clients to query on multiple decision contexts at once. All relevant policies for all specified decision contexts are then applied to the decision. This means we no longer need to iterate over all relevant decision contexts and send a separate decision query for each one; we can just send one query (per `greenwave_batch_size` subjects, still) with all the decision contexts in it. This makes the code simpler and will make Bodhi more efficient. Signed-off-by: Adam Williamson <awilliam@redhat.com>
AdamWill
force-pushed
the
combine-decision-contexts
branch
from
b470aa7
to
6f10399
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since release-engineering/greenwave#95 , greenwave allows clients to query on multiple decision contexts at once. All relevant policies for all specified decision contexts are then applied to the decision. This means we no longer need to iterate over all relevant decision contexts and send a separate decision query for each one; we can just send one query (per
greenwave_batch_sizesubjects, still) with all the decision contexts in it. This makes the code simpler and will make Bodhi more efficient.Signed-off-by: Adam Williamson awilliam@redhat.com