New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying days to stable #793

Merged
merged 1 commit into from Mar 8, 2016

Conversation

Projects
None yet
2 participants
@trishnaguha
Contributor

trishnaguha commented Mar 2, 2016

Modifying #779

@@ -1763,7 +1763,7 @@ def days_to_stable(self):
if comment.user.name == 'bodhi' and \
'can be pushed to stable now if the ' \
'maintainer wishes' in comment.text:
return (comment.timestamp - self.date_submitted).days
return (datetime.utcnow() - self.date_testing).days - self.release.mandatory_days_in_testing

This comment has been minimized.

@trishnaguha

trishnaguha Mar 2, 2016

Contributor

@lmacken @ralphbean Since the comment gets added just after self.release.mandatory_days_in_testing and we are considering datetime.utcnow() also, I have made (datetime.utcnow() - self.date_testing).days - self.release.mandatory_days_in_testing. Otherwise it would return negative value.

@trishnaguha trishnaguha referenced this pull request Mar 2, 2016

Merged

Time to stable #779

@lmacken

This comment has been minimized.

Member

lmacken commented Mar 2, 2016

So from what I understand we want to the number of days until the 'this update can now be pushed to stable' comment gets added automatically, right?

@trishnaguha

This comment has been minimized.

Contributor

trishnaguha commented Mar 4, 2016

@lmacken So it seems that we don't have to check for the comment "can be pushed to stable now if the maintainer wishes", since it gets added automatically after an update meets testing requirements right?
And also we need to display Days to Stable only when the status of an update is testing right?

@lmacken

This comment has been minimized.

Member

lmacken commented Mar 4, 2016

Yeah, that's right @trishnaguha

@trishnaguha

This comment has been minimized.

Contributor

trishnaguha commented Mar 8, 2016

@lmacken Yes it is about subtracting days in testing from self.release.mandatory_days_in_testing to get the number of days left. I did that because I was getting negative value. Now I understand why I was getting that. I have modified the PR. Thanks :)

@lmacken

This comment has been minimized.

Member

lmacken commented Mar 8, 2016

Cool, looks good to me :) Thanks @trishnaguha!

lmacken added a commit that referenced this pull request Mar 8, 2016

@lmacken lmacken merged commit 3812a55 into fedora-infra:develop Mar 8, 2016

@trishnaguha trishnaguha deleted the trishnaguha:time-to-stable branch Mar 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment