Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow re-use of solved captchas. #857

Merged
merged 1 commit into from Jul 6, 2016

Conversation

@ralphbean
Copy link
Contributor

commented Jul 6, 2016

If someone solved a captcha, they could re-use it over and over again for 5 minutes. Let's not let them do that. ;)

This adds the cipherkey of the captcha to the session as a kind of sentinel. We remove that flag once the captcha is used once. If they try to use their answer again, it will fail since the flag for that captcha is no longer in the session.

Fixes CVE-2016-1000008.

Disallow re-use of solved captchas.
Fixes CVE-2016-1000008.
@pypingou

This comment has been minimized.

Copy link
Member

commented Jul 6, 2016

LGTM :)

@puiterwijk

This comment has been minimized.

Copy link
Member

commented Jul 6, 2016

👍

@lmacken

This comment has been minimized.

Copy link
Member

commented Jul 6, 2016

Nice, thanks!

@lmacken lmacken merged commit 8abdaa4 into develop Jul 6, 2016

@lmacken lmacken deleted the feature/captcha-reuse branch Jul 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.