This repository has been archived by the owner on Jul 24, 2018. It is now read-only.
Create a new /info endpoint #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremycline
reviewed
Jan 12, 2017
|
|
||
| output['total_connections'] = model.Connection.search( | ||
| session, ip=ipaddr, cnt=True) | ||
| output['active_connections'] = model.Connection.by_ip( |
There was a problem hiding this comment.
Why not use search for both queries or by_ip for both queries? They seem to do the same thing in this case.
Edit: In all cases, actually
This endpoint aims at returning information about the session attached to the current IP.
Both method were basically doing the same thing now, so let's just keep one of them, as pointed out by Jeremy Cline in the review
|
Good call, I just dropped by_id() and replaced it with calls to search() instead. Thanks :) |
jeremycline
reviewed
Jan 13, 2017
|
|
||
| {% if ip in config['IP_UNLIMITED'] %} | ||
| This IP can have un-limited sessions. | ||
| {% elif ip in config['IP_UNLIMITED'] %} |
There was a problem hiding this comment.
I think maybe this was meant to be 'IP_BLOCKED' or similar?
|
Other than the one kwarg which I think is wrong, this looks good 👍 |
|
I'm going to merge this, thanks for the review :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This endpoint returns information about the number of sessions total and active associated
to this IP.