Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate fedimg to compose based #51

Merged
merged 5 commits into from Jun 27, 2016

Conversation

Projects
None yet
3 participants
@sayanchowdhury
Copy link
Member

commented Jun 7, 2016

No description provided.

@@ -26,13 +26,13 @@

import fedmsg.consumers
import fedmsg.encoding
import koji
import fedfind.release

This comment has been minimized.

Copy link
@pypingou

pypingou Jun 10, 2016

Member

This would need a change to the setup.py no?

Is it packaged for epel?

This comment has been minimized.

Copy link
@ralphbean

ralphbean Jun 20, 2016

Contributor

Looks like it is packaged for EPEL, yes: https://apps.fedoraproject.org/packages/fedfind

@sayanchowdhury sayanchowdhury force-pushed the compose-refactor branch from 3d62dcb to 1d0af12 Jun 20, 2016


```
sudo dnf install koji
sudo dnf install koji fedfind

This comment has been minimized.

Copy link
@sayanchowdhury

sayanchowdhury Jun 20, 2016

Author Member

@pypingou Updated the documentation to install fedfind through Fedora repo.

@@ -44,4 +44,4 @@ def upload(pool, urls):
services.append(EC2Service(url, virt_type=vt,
vol_type='gp2'))

results = pool.map(lambda s: s.upload(), services)
results = pool.map(lambda s: s.upload(compose_meta), services)

This comment has been minimized.

Copy link
@pypingou

pypingou Jun 20, 2016

Member

Just to be sure, is the difference in indentation meant?

This comment has been minimized.

Copy link
@sayanchowdhury

sayanchowdhury Jun 20, 2016

Author Member

Thanks :) Small indentation issue would have caused a major trouble! :)

@pypingou

This comment has been minimized.

Copy link
Member

commented Jun 20, 2016

w/o knowing much of the code nor having tested it, changes look sane to me

@@ -44,4 +44,4 @@ def upload(pool, urls, compose_meta):
services.append(EC2Service(url, virt_type=vt,
vol_type='gp2'))

results = pool.map(lambda s: s.upload(compose_meta), services)
results = pool.map(lambda s: s.upload(compose_meta), services)

This comment has been minimized.

Copy link
@ralphbean

ralphbean Jun 20, 2016

Contributor

Good catch!

@@ -27,7 +27,7 @@
NUM_PORTS = 2 * ((NUM_BASE_THREADS + NUM_ATOMIC_THREADS) + 1)

config = dict(
kojiconsumer=True,
fedimgconsumer=True,

This comment has been minimized.

Copy link
@ralphbean

ralphbean Jun 20, 2016

Contributor

Will need to remember to change this in our ansible configuration too when this gets deployed.

@ralphbean

This comment has been minimized.

Copy link
Contributor

commented Jun 20, 2016

👍 here.

@sayanchowdhury sayanchowdhury merged commit 62714e9 into develop Jun 27, 2016

@sayanchowdhury

This comment has been minimized.

Copy link
Member Author

commented Jun 27, 2016

Thanks :)

@pypingou pypingou deleted the compose-refactor branch Jun 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.