Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send image raw_url to fedmsg instead of the build_name #52

Merged
merged 1 commit into from Jul 12, 2016

Conversation

Projects
None yet
2 participants
@sayanchowdhury
Copy link
Member

commented Jul 11, 2016

Right now, the image_url passed to fedmsg is not an url rather the value same as that of image_name.
https://apps.fedoraproject.org/datagrepper/id?id=2016-805a2138-956b-470f-a24b-85d22af8b10f

@pypingou

This comment has been minimized.

Copy link
Member

commented Jul 12, 2016

Looks fine to me, do we expect this change to have an impact?

@sayanchowdhury

This comment has been minimized.

Copy link
Member Author

commented Jul 12, 2016

Not really but it would show the proper data. Also since I will be updating this change to fedmsg.meta

@pypingou

This comment has been minimized.

Copy link
Member

commented Jul 12, 2016

Cool 👍 for me then

@sayanchowdhury sayanchowdhury merged commit e066b6c into develop Jul 12, 2016

@sayanchowdhury

This comment has been minimized.

Copy link
Member Author

commented Jul 12, 2016

Thanks :)

@pypingou pypingou deleted the fix-messenger-url branch Jul 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.