Fedora packages do not have systemd service files #125

Closed
ilianaw opened this Issue Mar 6, 2013 · 7 comments

Comments

Projects
None yet
2 participants
@ilianaw
Contributor

ilianaw commented Mar 6, 2013

fedmsg packages in Fedora do not appear to have .service files for systemd to use.

(They do have .service files for D-Bus but that's different as far as I know.)

@ralphbean ralphbean referenced this issue in mokshaproject/moksha Mar 6, 2013

Merged

Collapse __init and __run consumers into one method. #2

@ralphbean

This comment has been minimized.

Show comment Hide comment
@ralphbean

ralphbean Mar 6, 2013

Contributor

Whoops. That moksha reference doesn't actually have anything to do with this issue.

Contributor

ralphbean commented Mar 6, 2013

Whoops. That moksha reference doesn't actually have anything to do with this issue.

@ralphbean

This comment has been minimized.

Show comment Hide comment
@ralphbean

ralphbean Mar 6, 2013

Contributor

I just verified that after running systemctl enable fedmsg-relay.service, fedmsg-relay did in fact start up after reboot.

Contributor

ralphbean commented Mar 6, 2013

I just verified that after running systemctl enable fedmsg-relay.service, fedmsg-relay did in fact start up after reboot.

@ralphbean

This comment has been minimized.

Show comment Hide comment
@ralphbean

ralphbean Mar 6, 2013

Contributor

I know almost nothing about systemd. Can you recommend a course of action, @ianweller?

Contributor

ralphbean commented Mar 6, 2013

I know almost nothing about systemd. Can you recommend a course of action, @ianweller?

@ilianaw

This comment has been minimized.

Show comment Hide comment
@ilianaw

ilianaw Mar 6, 2013

Contributor
[root@busrelay01 ianweller]# systemctl enable fedmsg-relay.service
Failed to issue method call: No such file or directory

This is a minimal Fedora 18 installation — the full list of RPMs I have installed is here: https://gist.github.com/ianweller/5101304

Contributor

ilianaw commented Mar 6, 2013

[root@busrelay01 ianweller]# systemctl enable fedmsg-relay.service
Failed to issue method call: No such file or directory

This is a minimal Fedora 18 installation — the full list of RPMs I have installed is here: https://gist.github.com/ianweller/5101304

@ilianaw

This comment has been minimized.

Show comment Hide comment
@ilianaw

ilianaw Mar 6, 2013

Contributor
[ianweller@busrelay01 ~]$ sudo yum whatprovides "*/fedmsg-relay.service"
No Matches found
Contributor

ilianaw commented Mar 6, 2013

[ianweller@busrelay01 ~]$ sudo yum whatprovides "*/fedmsg-relay.service"
No Matches found
@ralphbean

This comment has been minimized.

Show comment Hide comment
@ralphbean

ralphbean Mar 6, 2013

Contributor

Where should it go?

Contributor

ralphbean commented Mar 6, 2013

Where should it go?

@ralphbean

This comment has been minimized.

Show comment Hide comment
@ralphbean

ralphbean Mar 25, 2013

Contributor

As per conversation with @ianweller on IRC and a read over http://fedoraproject.org/wiki/Packaging:Systemd#Filesystem_locations

diff --git a/fedmsg.spec b/fedmsg.spec
index bd789da..92361f6 100644
--- a/fedmsg.spec
+++ b/fedmsg.spec
@@ -5,7 +5,7 @@

 Name:           fedmsg
 Version:        0.6.8
-Release:        1%{?dist}
+Release:        2%{?dist}
 Summary:        Tools for Fedora Infrastructure real-time messaging
 Group:          Applications/Internet
 License:        LGPLv2+
@@ -162,15 +162,15 @@ PYTHONPATH=$(pwd) python setup.py test
 %else
 %{__mkdir_p} %{buildroot}%{_datadir}/dbus-1/services
 %{__install} initsys/systemd/fedmsg-hub.service \
-    %{buildroot}%{_datadir}/dbus-1/services/org.fedoraproject.fedmsg-hub.service
+    %{buildroot}%{_unitdir}/fedmsg-hub.service
 %{__install} initsys/systemd/fedmsg-relay.service \
-    %{buildroot}%{_datadir}/dbus-1/services/org.fedoraproject.fedmsg-relay.service
+    %{buildroot}%{_unitdir}/fedmsg-relay.service
 %{__install} initsys/systemd/fedmsg-irc.service \
-    %{buildroot}%{_datadir}/dbus-1/services/org.fedoraproject.fedmsg-irc.service
+    %{buildroot}%{_unitdir}/fedmsg-irc.service
 %{__install} initsys/systemd/fedmsg-tweet.service \
-    %{buildroot}%{_datadir}/dbus-1/services/org.fedoraproject.fedmsg-tweet.service
+    %{buildroot}%{_unitdir}/fedmsg-tweet.service
 %{__install} initsys/systemd/fedmsg-gateway.service \
-    %{buildroot}%{_datadir}/dbus-1/services/org.fedoraproject.fedmsg-gateway.service
+    %{buildroot}%{_unitdir}/fedmsg-gateway.service
 %endif

 # Logrotate configuration
@@ -243,7 +243,7 @@ fi
 %if 0%{?rhel} && 0%{?rhel} <= 6
 %{_sysconfdir}/init.d/fedmsg-hub
 %else
-%{_datadir}/dbus-1/services/org.fedoraproject.fedmsg-hub.service
+%{_unitdir}/fedmsg-hub.service
 %endif

 %files relay
@@ -251,7 +251,7 @@ fi
 %if 0%{?rhel} && 0%{?rhel} <= 6
 %{_sysconfdir}/init.d/fedmsg-relay
 %else
-%config %{_datadir}/dbus-1/services/org.fedoraproject.fedmsg-relay.service
+%{_unitdir}/fedmsg-relay.service
 %endif

 %files irc
@@ -259,7 +259,7 @@ fi
 %if 0%{?rhel} && 0%{?rhel} <= 6
 %{_sysconfdir}/init.d/fedmsg-irc
 %else
-%config %{_datadir}/dbus-1/services/org.fedoraproject.fedmsg-irc.service
+%{_unitdir}/fedmsg-irc.service
 %endif

 %files tweet
@@ -267,7 +267,7 @@ fi
 %if 0%{?rhel} && 0%{?rhel} <= 6
 %{_sysconfdir}/init.d/fedmsg-tweet
 %else
-%config %{_datadir}/dbus-1/services/org.fedoraproject.fedmsg-tweet.service
+%{_unitdir}/fedmsg-tweet.service
 %endif

 %files gateway
@@ -275,10 +275,15 @@ fi
 %if 0%{?rhel} && 0%{?rhel} <= 6
 %{_sysconfdir}/init.d/fedmsg-gateway
 %else
-%config %{_datadir}/dbus-1/services/org.fedoraproject.fedmsg-gateway.service
+%{_unitdir}/fedmsg-gateway.service
 %endif

 %changelog
+* Mon Mar 25 2013 Ralph Bean <rbean@redhat.com> - 0.6.8-2
+- Moved .service files from a dbus folder to a systemd folder
+  https://github.com/fedora-infra/fedmsg/issues/125
+- Marked .service files as no longer %%config files.
+
 * Mon Mar 04 2013 Ralph Bean <rbean@redhat.com> - 0.6.8-1
 - New fedmsg-tail --gource option for visualizations.
 - fedmsg-tweet reorganized to be more similar to other daemons.
Contributor

ralphbean commented Mar 25, 2013

As per conversation with @ianweller on IRC and a read over http://fedoraproject.org/wiki/Packaging:Systemd#Filesystem_locations

diff --git a/fedmsg.spec b/fedmsg.spec
index bd789da..92361f6 100644
--- a/fedmsg.spec
+++ b/fedmsg.spec
@@ -5,7 +5,7 @@

 Name:           fedmsg
 Version:        0.6.8
-Release:        1%{?dist}
+Release:        2%{?dist}
 Summary:        Tools for Fedora Infrastructure real-time messaging
 Group:          Applications/Internet
 License:        LGPLv2+
@@ -162,15 +162,15 @@ PYTHONPATH=$(pwd) python setup.py test
 %else
 %{__mkdir_p} %{buildroot}%{_datadir}/dbus-1/services
 %{__install} initsys/systemd/fedmsg-hub.service \
-    %{buildroot}%{_datadir}/dbus-1/services/org.fedoraproject.fedmsg-hub.service
+    %{buildroot}%{_unitdir}/fedmsg-hub.service
 %{__install} initsys/systemd/fedmsg-relay.service \
-    %{buildroot}%{_datadir}/dbus-1/services/org.fedoraproject.fedmsg-relay.service
+    %{buildroot}%{_unitdir}/fedmsg-relay.service
 %{__install} initsys/systemd/fedmsg-irc.service \
-    %{buildroot}%{_datadir}/dbus-1/services/org.fedoraproject.fedmsg-irc.service
+    %{buildroot}%{_unitdir}/fedmsg-irc.service
 %{__install} initsys/systemd/fedmsg-tweet.service \
-    %{buildroot}%{_datadir}/dbus-1/services/org.fedoraproject.fedmsg-tweet.service
+    %{buildroot}%{_unitdir}/fedmsg-tweet.service
 %{__install} initsys/systemd/fedmsg-gateway.service \
-    %{buildroot}%{_datadir}/dbus-1/services/org.fedoraproject.fedmsg-gateway.service
+    %{buildroot}%{_unitdir}/fedmsg-gateway.service
 %endif

 # Logrotate configuration
@@ -243,7 +243,7 @@ fi
 %if 0%{?rhel} && 0%{?rhel} <= 6
 %{_sysconfdir}/init.d/fedmsg-hub
 %else
-%{_datadir}/dbus-1/services/org.fedoraproject.fedmsg-hub.service
+%{_unitdir}/fedmsg-hub.service
 %endif

 %files relay
@@ -251,7 +251,7 @@ fi
 %if 0%{?rhel} && 0%{?rhel} <= 6
 %{_sysconfdir}/init.d/fedmsg-relay
 %else
-%config %{_datadir}/dbus-1/services/org.fedoraproject.fedmsg-relay.service
+%{_unitdir}/fedmsg-relay.service
 %endif

 %files irc
@@ -259,7 +259,7 @@ fi
 %if 0%{?rhel} && 0%{?rhel} <= 6
 %{_sysconfdir}/init.d/fedmsg-irc
 %else
-%config %{_datadir}/dbus-1/services/org.fedoraproject.fedmsg-irc.service
+%{_unitdir}/fedmsg-irc.service
 %endif

 %files tweet
@@ -267,7 +267,7 @@ fi
 %if 0%{?rhel} && 0%{?rhel} <= 6
 %{_sysconfdir}/init.d/fedmsg-tweet
 %else
-%config %{_datadir}/dbus-1/services/org.fedoraproject.fedmsg-tweet.service
+%{_unitdir}/fedmsg-tweet.service
 %endif

 %files gateway
@@ -275,10 +275,15 @@ fi
 %if 0%{?rhel} && 0%{?rhel} <= 6
 %{_sysconfdir}/init.d/fedmsg-gateway
 %else
-%config %{_datadir}/dbus-1/services/org.fedoraproject.fedmsg-gateway.service
+%{_unitdir}/fedmsg-gateway.service
 %endif

 %changelog
+* Mon Mar 25 2013 Ralph Bean <rbean@redhat.com> - 0.6.8-2
+- Moved .service files from a dbus folder to a systemd folder
+  https://github.com/fedora-infra/fedmsg/issues/125
+- Marked .service files as no longer %%config files.
+
 * Mon Mar 04 2013 Ralph Bean <rbean@redhat.com> - 0.6.8-1
 - New fedmsg-tail --gource option for visualizations.
 - fedmsg-tweet reorganized to be more similar to other daemons.

@ralphbean ralphbean closed this Mar 25, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment