Topic prefix org.fedoraproject is hardcoded in various places #126

Closed
ianweller opened this Issue Mar 6, 2013 · 4 comments

Projects

None yet

2 participants

@ianweller
Member

If config_prefix (and config_prefix_re) is changed in /etc/fedmsg.d/*.py, fedmsg-relay doesn't actually relay any messages from fedmsg-logger because org.fedoraproject.* is hardcoded in commands/relay.py.

Perhaps commands and the like should use config_prefix?

@ralphbean
Collaborator

Nice catch! Definitely!

@ralphbean
Collaborator

Ugh, this is problematic. Moksha (in the __init_consumers method) uses a Consumer's topic before the class is instantiated. It accesses it as a class attribute.

If we were to dynamically assign the topic of a Consumer using the contents of /etc/fedmsg.d/*.py, it would have to be done at import time which is bad news, almost always.

This will, I think, require a patch to Moksha to avoid accessing that attribute until after instantiating each Consumer.

@ralphbean ralphbean referenced this issue in mokshaproject/moksha Mar 6, 2013
Merged

Collapse __init and __run consumers into one method. #2

@ralphbean
Collaborator

Ok, that patch should be in place with moksha.hub>=1.1.3 (not yet released).

@ralphbean
Collaborator
@ralphbean ralphbean added a commit that closed this issue Apr 10, 2013
@ralphbean ralphbean Remove hardcoded topic prefixes.
Fixes #126.
b89fd35
@ralphbean ralphbean closed this in b89fd35 Apr 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment