New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/remove hardcoded topics #133

Merged
merged 4 commits into from Apr 10, 2013

Conversation

Projects
None yet
3 participants
@ralphbean
Contributor

ralphbean commented Apr 10, 2013

fedmsg was designed to not be fedora-specific, but I cut a couple corners on the first iterations. One of those was that I hardcoded the "org.fedoraproject" topic prefix in a couple places.

With the debian community and @olasd asking about fedmsg, that stuff needs cleaned up!

These commits take care of that and fix #126.

@pypingou

This comment has been minimized.

Show comment
Hide comment
@pypingou

pypingou Apr 10, 2013

Member

Looks good to me 🐹

Member

pypingou commented Apr 10, 2013

Looks good to me 🐹

@ralphbean

This comment has been minimized.

Show comment
Hide comment
@ralphbean

ralphbean Apr 10, 2013

Contributor

:) Thanks @pypingou!

Contributor

ralphbean commented Apr 10, 2013

:) Thanks @pypingou!

ralphbean added a commit that referenced this pull request Apr 10, 2013

@ralphbean ralphbean merged commit ad86b1f into develop Apr 10, 2013

1 check failed

default The Travis build could not complete due to an error
Details
if 'topic_prefix_re' not in config:
# Turn "org.fedoraproject" into "org\.fedoraproject\.(dev|stg|prod)"
config['topic_prefix_re'] = config['topic_prefix'].replace('.', '\.')\
+ '\.(%s)' % '|'.join(VALID_ENVIRONMENTS)

This comment has been minimized.

@lmacken

lmacken Apr 19, 2013

Member

Don't those need to be raw strings?

@lmacken

lmacken Apr 19, 2013

Member

Don't those need to be raw strings?

@ralphbean ralphbean deleted the feature/remove-hardcoded-topics branch Feb 26, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment