New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn testing Python 2.6 in Travis on #382

Merged
merged 6 commits into from Oct 28, 2016

Conversation

Projects
None yet
3 participants
@jeremycline
Member

jeremycline commented Oct 27, 2016

Twisted has dropped Python 2.6 support, but fedmsg still needs to be
Python 2.6 compatible. Since moksha.hub, the dependency that pulls in
Twisted, doesn't require a specific version of Twisted, we can just
install it before we install the requirements if the environment is
Python 2.6.

Signed-off-by: Jeremy Cline jeremy@jcline.org

ashcrow and others added some commits Oct 8, 2016

Turn testing Python 2.6 in Travis on
Twisted has dropped Python 2.6 support, but fedmsg still needs to be
Python 2.6 compatible. Since moksha.hub, the dependency that pulls in
Twisted, doesn't require a specific version of Twisted, we can just
install it before we install the requirements if the environment is
Python 2.6.

Signed-off-by: Jeremy Cline <jeremy@jcline.org>
@jeremycline

This comment has been minimized.

Member

jeremycline commented Oct 27, 2016

This pulls in all the commits for #379 - we can either merge this and close #379, or merge #379 and rebase this. I do not mind either way.

.travis.yml Outdated
- pip install -e .[commands,consumers]
- pip install nose mock sqlalchemy unittest2

This comment has been minimized.

@pypingou

pypingou Oct 27, 2016

Member

isn't unittest2 required in 2.6?

This comment has been minimized.

@jeremycline

jeremycline Oct 27, 2016

Member

It is, and it's placed in the tests_require list in setup.py

@jeremycline jeremycline force-pushed the jeremycline:enable-2.6-testing branch 3 times, most recently from 49629ab to 4af7adf Oct 27, 2016

Update pip before starting the Travis tests
Signed-off-by: Jeremy Cline <jeremy@jcline.org>

@jeremycline jeremycline force-pushed the jeremycline:enable-2.6-testing branch from 4af7adf to bd45211 Oct 27, 2016

@jeremycline

This comment has been minimized.

Member

jeremycline commented Oct 27, 2016

I added a test-requirements.txt file with all the dependencies so we can pip install them. Simply doing python setup.py nosetests to install the test requirements was causing installations to fail on 2.6 (for reasons I did not dig into too deeply).

@pypingou

This comment has been minimized.

Member

pypingou commented Oct 28, 2016

👍 for me

@jeremycline jeremycline merged commit 706d494 into fedora-infra:develop Oct 28, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jeremycline jeremycline deleted the jeremycline:enable-2.6-testing branch Oct 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment