New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library branding #391

Merged
merged 4 commits into from Dec 2, 2016

Conversation

Projects
None yet
4 participants
@sijis
Contributor

sijis commented Nov 24, 2016

Thiis changes the references for Fedora Messaging to Federated Message Bus.

Related to discussions in #373, #383.

@sayanchowdhury

This comment has been minimized.

Member

sayanchowdhury commented Nov 24, 2016

Looks good to me 👍

@pypingou

This comment has been minimized.

Member

pypingou commented Nov 28, 2016

Same here, so let's merge :)

@pypingou

This comment has been minimized.

Member

pypingou commented Nov 28, 2016

@ralphbean do you think you could re-generate the doc at fedmsg.com with this change?

@ralphbean

One change needed in README.rst I think.

README.rst Outdated
@@ -1,9 +1,10 @@
fedmsg -- Fedora Messaging Client API
fedmsg -- Federated Message Bus Client API
=====================================

This comment has been minimized.

@ralphbean

ralphbean Dec 1, 2016

Contributor

I think the underline is supposed to match the length of the title here.

This comment has been minimized.

@sijis

sijis Dec 1, 2016

Contributor

Good point. I adjusted it to match.

@sijis sijis force-pushed the sijis:fixes/library_branding branch from 0e78f2e to 7bfe39a Dec 1, 2016

@sijis

This comment has been minimized.

Contributor

sijis commented Dec 2, 2016

I've made the suggested updates in README.rst.

@sijis

This comment has been minimized.

Contributor

sijis commented Dec 2, 2016

I've also rebased from develop branch too.

@ralphbean

Awesome. Thanks!

@ralphbean ralphbean merged commit f9b779f into fedora-infra:develop Dec 2, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sijis sijis deleted the sijis:fixes/library_branding branch Dec 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment