New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only check for stomp messages after we decoded any ZMQMessage #393

Merged
merged 1 commit into from Dec 1, 2016

Conversation

Projects
None yet
2 participants
@puiterwijk
Member

puiterwijk commented Dec 1, 2016

Signed-off-by: Patrick Uiterwijk puiterwijk@redhat.com

Only check for stomp messages after we decoded any ZMQMessage
Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>

@puiterwijk puiterwijk added the bug label Dec 1, 2016

@puiterwijk

This comment has been minimized.

Member

puiterwijk commented Dec 1, 2016

This is a pretty serious bug that will very likely break a lot.

@ralphbean

This comment has been minimized.

Contributor

ralphbean commented Dec 1, 2016

Hm, this is reverting more than it needs to. The stuff from #388 should be ok.

@ralphbean

This comment has been minimized.

Contributor

ralphbean commented Dec 1, 2016

After reading through a second time, this looks good now.

@ralphbean ralphbean merged commit a881149 into develop Dec 1, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ralphbean ralphbean deleted the fix-stomp branch Dec 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment