New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove env validation. #406

Merged
merged 1 commit into from Apr 7, 2017

Conversation

Projects
None yet
2 participants
@ralphbean
Contributor

ralphbean commented Apr 5, 2017

We have a case where we want the environment to be something other than dev,
stg, or prod. I figure there's not really a reason to enforce any convention
in the code like this.

@ralphbean

This comment has been minimized.

Contributor

ralphbean commented Apr 5, 2017

Failing tests should be fixed by #405.

Remove env validation.
We have a case where we want the environment to be something other than dev,
stg, or prod.  I figure there's not really a reason to enforce any convention
in the code like this.

@ralphbean ralphbean force-pushed the ralphbean:feature/no-env-validation branch from 08d5d04 to 08036fe Apr 6, 2017

@ralphbean

This comment has been minimized.

Contributor

ralphbean commented Apr 6, 2017

Rebased on top of #405.

@pypingou

This comment has been minimized.

Member

pypingou commented Apr 6, 2017

Looks fine to me :)

@ralphbean

This comment has been minimized.

Contributor

ralphbean commented Apr 7, 2017

Thanks @pypingou!

@ralphbean ralphbean merged commit eccbdc4 into fedora-infra:develop Apr 7, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ralphbean ralphbean deleted the ralphbean:feature/no-env-validation branch Apr 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment