New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass along headers for *all* consumers, not just the irc bot. #437

Merged
merged 1 commit into from Jun 28, 2017

Conversation

Projects
None yet
4 participants
@ralphbean
Contributor

ralphbean commented Jun 28, 2017

This is on top of #432. We realized we had the same problem with datanommer that we saw in the irc bot.

@ralphbean ralphbean requested a review from jeremycline Jun 28, 2017

@ralphbean

This comment has been minimized.

Contributor

ralphbean commented Jun 28, 2017

@codecov-io

This comment has been minimized.

codecov-io commented Jun 28, 2017

Codecov Report

Merging #437 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #437      +/-   ##
===========================================
- Coverage    48.54%   48.54%   -0.01%     
===========================================
  Files           31       31              
  Lines         1963     1961       -2     
  Branches       320      319       -1     
===========================================
- Hits           953      952       -1     
  Misses         913      913              
+ Partials        97       96       -1
Impacted Files Coverage Δ
fedmsg/consumers/ircbot.py 40.66% <ø> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c91bcc3...bd03eb3. Read the comment docs.

@mikebonnet

This comment has been minimized.

mikebonnet commented Jun 28, 2017

+1 Works for me.

@jeremycline

This is fine with me, although I'm not crazy about stuffing things into the message body.

One thing I've been mulling on since I worked on the crypto module rewrite is that is would probably be nice to have a message envelope. Placing the signature inside the data structure that was just signed makes it difficult to verify and isn't really relevant to the user. They just want to know it's a valid message. Maybe this "envelope" would be a good place for headers in the long term.

@ralphbean

This comment has been minimized.

Contributor

ralphbean commented Jun 28, 2017

Placing the signature inside the data structure that was just signed makes it difficult to verify and isn't really relevant to the user.

Agreed. That was a mistake in hindsight.

@ralphbean

This comment has been minimized.

Contributor

ralphbean commented Jun 28, 2017

@jeremycline, I don't understand why codecov is blocking the merge here. Any insights?

@jeremycline

This comment has been minimized.

Member

jeremycline commented Jun 28, 2017

I set it so coverage was not allowed to drop from a pull request. It looks like the coverage report isn't including fedmsg/consumer/__init__.py for some reason, so it just sees the hit count going down. Maybe some weird rounding is also occurring. I've turned off the requirement for project coverage increasing for the moment.

@jeremycline jeremycline merged commit 05c35e7 into develop Jun 28, 2017

3 of 4 checks passed

codecov/project 48.54% (-0.01%) compared to c91bcc3
Details
codecov/patch Coverage not affected when comparing c91bcc3...bd03eb3
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@jeremycline jeremycline deleted the feature/headers branch Jun 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment