Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Pass along headers for *all* consumers, not just the irc bot. #437
@@ Coverage Diff @@ ## develop #437 +/- ## =========================================== - Coverage 48.54% 48.54% -0.01% =========================================== Files 31 31 Lines 1963 1961 -2 Branches 320 319 -1 =========================================== - Hits 953 952 -1 Misses 913 913 + Partials 97 96 -1
This is fine with me, although I'm not crazy about stuffing things into the message body.
One thing I've been mulling on since I worked on the crypto module rewrite is that is would probably be nice to have a message envelope. Placing the signature inside the data structure that was just signed makes it difficult to verify and isn't really relevant to the user. They just want to know it's a valid message. Maybe this "envelope" would be a good place for headers in the long term.
I set it so coverage was not allowed to drop from a pull request. It looks like the coverage report isn't including