New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The m2crypto tests are skipped when cryptography is missing #446

Merged
merged 1 commit into from Jul 13, 2017

Conversation

Projects
None yet
3 participants
@jeremycline
Member

jeremycline commented Jul 13, 2017

The intention was to run the m2crypto tests only when m2crypto is
present, but the actual check was for cryptography. Oops.

Signed-off-by: Jeremy Cline jeremy@jcline.org

The m2crypto tests are skipped when cryptography is missing
The intention was to run the m2crypto tests only when m2crypto is
present, but the actual check was for cryptography. Oops.

Signed-off-by: Jeremy Cline <jeremy@jcline.org>
@codecov-io

This comment has been minimized.

codecov-io commented Jul 13, 2017

Codecov Report

Merging #446 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #446   +/-   ##
========================================
  Coverage    55.81%   55.81%           
========================================
  Files           31       31           
  Lines         1917     1917           
  Branches       301      301           
========================================
  Hits          1070     1070           
  Misses         751      751           
  Partials        96       96

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b2028f...ef93971. Read the comment docs.

@cverna

cverna approved these changes Jul 13, 2017

LGTM

@jeremycline jeremycline merged commit 927a975 into fedora-infra:develop Jul 13, 2017

3 checks passed

codecov/patch Coverage not affected when comparing 8b2028f...ef93971
Details
codecov/project 55.81% remains the same compared to 8b2028f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jeremycline jeremycline deleted the jeremycline:fix-m2crypt-check branch Jul 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment