New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the dependency on nose #448

Merged
merged 1 commit into from Jul 14, 2017

Conversation

Projects
None yet
3 participants
@jeremycline
Member

jeremycline commented Jul 13, 2017

Now that we use pytest, we should not depend on nose.

Signed-off-by: Jeremy Cline jeremy@jcline.org

Remove the dependency on nose
Now that we use pytest, we should not depend on nose.

Signed-off-by: Jeremy Cline <jeremy@jcline.org>
@codecov-io

This comment has been minimized.

codecov-io commented Jul 13, 2017

Codecov Report

Merging #448 into develop will decrease coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #448      +/-   ##
===========================================
- Coverage    55.81%   55.65%   -0.16%     
===========================================
  Files           31       31              
  Lines         1917     1917              
  Branches       301      301              
===========================================
- Hits          1070     1067       -3     
- Misses         751      754       +3     
  Partials        96       96
Impacted Files Coverage Δ
fedmsg/replay/__init__.py 32.39% <0%> (-2.82%) ⬇️
fedmsg/meta/__init__.py 70.76% <0%> (-0.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b2028f...3e66d34. Read the comment docs.

@pypingou

This comment has been minimized.

Member

pypingou commented Jul 13, 2017

Looks fine to me

@jeremycline jeremycline merged commit 4fe9558 into fedora-infra:develop Jul 14, 2017

2 of 3 checks passed

codecov/project 55.65% (-0.16%) compared to 8b2028f
Details
codecov/patch Coverage not affected when comparing 8b2028f...3e66d34
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jeremycline jeremycline deleted the jeremycline:remove-nose-dependency branch Jul 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment