Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
ZMQMessage isn't iterable, use __dict__ #462
Okay, none of the moksha APIs are defined or documented and it's a tangled mess of functions accepting "messages" so it's not trivial to say what might break if we suddenly switch from the ZMQMessage class to a plain dict.
My inclination is to either revert the commit that added this and spend some time auditing everything and writing careful tests, or add a check to see if it's a dict before placing headers in the body. @ralphbean, since this is a feature you needed, do you have an opinion one way or the other?
referenced this pull request
Aug 9, 2017
@@ Coverage Diff @@ ## develop #462 +/- ## ======================================== Coverage 58.91% 58.91% ======================================== Files 29 29 Lines 1835 1835 Branches 303 303 ======================================== Hits 1081 1081 Misses 667 667 Partials 87 87