New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 2.6 support #469

Merged
merged 1 commit into from Aug 17, 2017

Conversation

Projects
None yet
3 participants
@jeremycline
Member

jeremycline commented Aug 16, 2017

See #418 and mokshaproject/moksha#48.

Signed-off-by: Jeremy Cline jeremy@jcline.org

@codecov

This comment has been minimized.

codecov bot commented Aug 16, 2017

Codecov Report

Merging #469 into develop will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #469      +/-   ##
===========================================
- Coverage    58.92%   58.82%   -0.11%     
===========================================
  Files           29       29              
  Lines         1831     1831              
  Branches       303      303              
===========================================
- Hits          1079     1077       -2     
- Misses         665      667       +2     
  Partials        87       87
Impacted Files Coverage Δ
fedmsg/crypto/utils.py 58.46% <0%> (-3.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4bc6df...5c6b3b2. Read the comment docs.

@pypingou

There will be a conflict with #470 but easy enough to fix.

👍 for me

Backwards incompatible changes
------------------------------
* Python 2.6 is no longer supported

This comment has been minimized.

@pypingou

pypingou Aug 17, 2017

Member

Will conflict with #470

This comment has been minimized.

@jeremycline

jeremycline Aug 17, 2017

Member

I figured this way I'd be forced to write the release note instead of putting it off until I want to tag the release 😄

Remove Python 2.6 support
Signed-off-by: Jeremy Cline <jeremy@jcline.org>

@jeremycline jeremycline force-pushed the jeremycline:remove-py26 branch from deab99e to 5c6b3b2 Aug 17, 2017

@jeremycline

This comment has been minimized.

Member

jeremycline commented Aug 17, 2017

Not sure what the deal is with codecov here, the report I generate locally shows that line as covered and there's no reason I can see that that code only would have been exercised in Python 2.6 alone.

@jeremycline jeremycline merged commit d7da47f into fedora-infra:develop Aug 17, 2017

2 of 3 checks passed

codecov/project 58.82% (-0.11%) compared to f4bc6df
Details
codecov/patch Coverage not affected when comparing f4bc6df...5c6b3b2
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jeremycline jeremycline deleted the jeremycline:remove-py26 branch Aug 17, 2017

@frenzymadness

This comment has been minimized.

Contributor

frenzymadness commented Aug 17, 2017

Perfect work! Side note: The specfile should be also modified. Should I create a bug in bugzilla?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment