New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the --daemon related code #470

Merged
merged 2 commits into from Aug 17, 2017

Conversation

Projects
None yet
2 participants
@jeremycline
Member

jeremycline commented Aug 16, 2017

In #434 we deprecated the --daemon option for removal in 1.0.0. This removes the actual code.

jeremycline added some commits Aug 16, 2017

Remove the SysV init scripts
--daemonize was deprecated in 0.19 for removal in 1.0.0 and these
scripts relied on that flag.

Signed-off-by: Jeremy Cline <jeremy@jcline.org>
Remove the --daemon related code
Signed-off-by: Jeremy Cline <jeremy@jcline.org>
@codecov

This comment has been minimized.

codecov bot commented Aug 16, 2017

Codecov Report

Merging #470 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #470      +/-   ##
===========================================
+ Coverage    58.91%   58.92%   +0.01%     
===========================================
  Files           29       29              
  Lines         1835     1831       -4     
  Branches       303      303              
===========================================
- Hits          1081     1079       -2     
+ Misses         667      665       -2     
  Partials        87       87
Impacted Files Coverage Δ
fedmsg/commands/ircbot.py 0% <ø> (ø) ⬆️
fedmsg/commands/relay.py 75.86% <ø> (-0.81%) ⬇️
fedmsg/commands/gateway.py 0% <ø> (ø) ⬆️
fedmsg/commands/hub.py 58.82% <ø> (-1.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eeb0c86...e684c80. Read the comment docs.

@pypingou

LGTM

@pypingou pypingou referenced this pull request Aug 17, 2017

Merged

Remove Python 2.6 support #469

@jeremycline jeremycline merged commit f4bc6df into fedora-infra:develop Aug 17, 2017

3 checks passed

codecov/patch Coverage not affected when comparing eeb0c86...e684c80
Details
codecov/project 58.92% (+0.01%) compared to eeb0c86
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jeremycline jeremycline deleted the jeremycline:remove-daemonize branch Aug 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment