New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed logger to use module name #479

Merged
merged 1 commit into from Sep 8, 2017

Conversation

Projects
None yet
3 participants
@cha-ku
Contributor

cha-ku commented Sep 8, 2017

Change with reference to Issue #441

@codecov

This comment has been minimized.

codecov bot commented Sep 8, 2017

Codecov Report

Merging #479 into develop will not change coverage.
The diff coverage is 75%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #479   +/-   ##
========================================
  Coverage    58.82%   58.82%           
========================================
  Files           29       29           
  Lines         1831     1831           
  Branches       303      303           
========================================
  Hits          1077     1077           
  Misses         667      667           
  Partials        87       87
Impacted Files Coverage Δ
fedmsg/consumers/dummy.py 78.57% <0%> (ø) ⬆️
fedmsg/meta/__init__.py 79.23% <100%> (ø) ⬆️
fedmsg/core.py 45.6% <100%> (ø) ⬆️
fedmsg/consumers/ircbot.py 50.91% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04d94be...f385f15. Read the comment docs.

@bowlofeggs

LGTM, though the coverage.io bot is upset.

@@ -38,5 +38,5 @@ def __init__(self, hub):
def consume(self, msg):
# Do nothing.
log = logging.getLogger("moksha.hub")
log = logging.getLogger(__name__)

This comment has been minimized.

@bowlofeggs

bowlofeggs Sep 8, 2017

Member

This line is missing test coverage.

@jeremycline

This comment has been minimized.

Member

jeremycline commented Sep 8, 2017

Thanks @chaiku!

Normally I require 100% diff coverage, but in this case I think it's a pretty safe change and the coverage isn't going down.

@jeremycline jeremycline merged commit c537ebe into fedora-infra:develop Sep 8, 2017

2 of 3 checks passed

codecov/patch 75% of diff hit (target 100%)
Details
codecov/project 58.82% (+0%) compared to 04d94be
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment