New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alter how the tests determine if cryptography is available #482

Merged
merged 1 commit into from Sep 29, 2017

Conversation

Projects
None yet
2 participants
@jeremycline
Member

jeremycline commented Sep 28, 2017

Rather than re-importing cryptography and m2crypto to detect what tests
to run in the test module, just import from the x509_ng module. This
fixes issues when running the tests with an old pyOpenSSL library that
doesn't provide the APIs we need.

Signed-off-by: Jeremy Cline jeremy@jcline.org

Alter how the tests determine if cryptography is available
Rather than re-importing cryptography and m2crypto to detect what tests
to run in the test module, just import from the x509_ng module. This
fixes issues when running the tests with an old pyOpenSSL library that
doesn't provide the APIs we need.

Signed-off-by: Jeremy Cline <jeremy@jcline.org>
@codecov

This comment has been minimized.

codecov bot commented Sep 28, 2017

Codecov Report

Merging #482 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #482   +/-   ##
========================================
  Coverage    58.82%   58.82%           
========================================
  Files           29       29           
  Lines         1831     1831           
  Branches       303      303           
========================================
  Hits          1077     1077           
  Misses         667      667           
  Partials        87       87

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c57d60...a3b9ac5. Read the comment docs.

@pypingou

This comment has been minimized.

Member

pypingou commented Sep 29, 2017

Looks find to me

@jeremycline jeremycline merged commit 73425a9 into fedora-infra:develop Sep 29, 2017

3 checks passed

codecov/patch Coverage not affected when comparing 1c57d60...a3b9ac5
Details
codecov/project 58.82% remains the same compared to 1c57d60
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jeremycline jeremycline deleted the jeremycline:precise-lib-check-tests branch Sep 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment