Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substantial rewrite + extension of compose.* tests #455

Merged
merged 1 commit into from Dec 12, 2017

Conversation

Projects
None yet
4 participants
@AdamWill
Copy link
Contributor

commented Dec 9, 2017

The tests for the 'compose' message topic were missing rather
a lot of coverage. This commit substantially revises and
extends the tests such that they should hopefully cover just
about all message forms that have existed. This commit does not
change the behaviour of the processor at all, and so some of the
expected values are sort of 'wrong' - they represent what the
processor currently does, even though the newly-added test makes
it clear the processor should probably do something else.
Subsequent commits will improve the processor behaviour, and of
course update the tests where appropriate.

Signed-off-by: Adam Williamson awilliam@redhat.com

Substantial rewrite + extension of compose.* tests
The tests for the 'compose' message topic were missing rather
a lot of coverage. This commit substantially revises and
extends the tests such that they should hopefully cover just
about all message forms that have existed. This commit does not
change the behaviour of the processor at all, and so some of the
expected values are sort of 'wrong' - they represent what the
processor currently does, even though the newly-added test makes
it clear the processor should probably do something else.
Subsequent commits will improve the processor behaviour, and of
course update the tests where appropriate.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
@AdamWill

This comment has been minimized.

Copy link
Contributor Author

commented Dec 9, 2017

Note, there are also some corrections to existing tests. e.g. the changes to the branch values - I checked old messages on datagrepper and the value really has always been just the number, i.e. 18 not f18.

@AdamWill

This comment has been minimized.

Copy link
Contributor Author

commented Dec 9, 2017

@ralphbean , @puiterwijk - I would also tag mohan, but I can't find his github ID, if he has one.

@AdamWill

This comment has been minimized.

Copy link
Contributor Author

commented Dec 9, 2017

Note, because this is such a big rewrite but all the test methods look quite similar, the diff is fairly nonsensical and impossible to read. You're better off just reading old and new copies of the file side-by-side to review this, I think.

@ralphbean

This comment has been minimized.

Copy link
Contributor

commented Dec 11, 2017

@ralphbean
Copy link
Contributor

left a comment

@AdamWill, there is so much here. It looks like you went through it all with a fine-toothed comb. 👍 from me (although I don't have rights to merge).

@mohanboddu

This comment has been minimized.

Copy link

commented Dec 12, 2017

LGTM, 👍

@AdamWill

This comment has been minimized.

Copy link
Contributor Author

commented Dec 12, 2017

@ralphbean are you sure you can't merge this? I see many commits from you in the log. if not, @pypingou , could you do the honors? Thanks :)

@pypingou

This comment has been minimized.

Copy link
Member

commented Dec 12, 2017

Thanks! :)

PS: Ralph removed himself from the group and thus lost the merge abilities :(

@pypingou pypingou merged commit bdce9c8 into fedora-infra:develop Dec 12, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.