Fix the mailman_schema example to work with Message.body #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you run Black and rebase please? |
The message ``body`` variable is used by the Message class, but the example schema is still defining a property using that name. See https://pagure.io/fedora-commops/fedora-happiness-packets/issue/96 Signed-off-by: Jeremy Cline <jcline@redhat.com>
jeremycline
force-pushed
the
fix-mailman-example
branch
from
5b02d1f
to
9394ad5
Compare
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
=======================================
Coverage 96.92% 96.92%
=======================================
Files 13 13
Lines 1106 1106
Branches 155 155
=======================================
Hits 1072 1072
Misses 24 24
Partials 10 10Continue to review full report at Codecov.
|
abompard
approved these changes
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The message
bodyvariable is used by the Message class, but theexample schema is still defining a property using that name.
See https://pagure.io/fedora-commops/fedora-happiness-packets/issue/96
Signed-off-by: Jeremy Cline jcline@redhat.com