Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix authentication with x509 certificates #29

Merged
merged 1 commit into from Aug 20, 2018

Conversation

@jeremycline
Copy link
Member

commented Aug 17, 2018

The connection parameters need to set the credentials type to 'EXTERNAL'
in order for x509 client certificate authentication to work. Do so if
both the cert and key is present.

Signed-off-by: Jeremy Cline jcline@redhat.com

Fix authentication with x509 certificates
The connection parameters need to set the credentials type to 'EXTERNAL'
in order for x509 client certificate authentication to work. Do so if
both the cert and key is present.

Signed-off-by: Jeremy Cline <jcline@redhat.com>
@codecov-io

This comment has been minimized.

Copy link

commented Aug 17, 2018

Codecov Report

Merging #29 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   88.41%   88.43%   +0.01%     
==========================================
  Files          10       10              
  Lines         751      752       +1     
  Branches      105      105              
==========================================
+ Hits          664      665       +1     
  Misses         60       60              
  Partials       27       27
Impacted Files Coverage Δ
fedora_messaging/_session.py 81.08% <100%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2783c8...c554ae3. Read the comment docs.

@abompard
Copy link
Member

left a comment

This looks great. Is there something to do on the Twisted side of things?

@jeremycline

This comment has been minimized.

Copy link
Member Author

commented Aug 20, 2018

Yes, I've got a branch in progress, I should have a PR tomorrow

@jeremycline jeremycline merged commit fa9b77f into fedora-infra:master Aug 20, 2018

2 checks passed

DCO All commits have a DCO sign-off from the author
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jeremycline jeremycline deleted the jeremycline:fix-ssl-auth branch Aug 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.