Remove the unused --amqp-url parameter from the CLI #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
==========================================
- Coverage 92.38% 92.35% -0.03%
==========================================
Files 11 11
Lines 801 798 -3
Branches 110 110
==========================================
- Hits 740 737 -3
Misses 40 40
Partials 21 21
Continue to review full report at Codecov.
|
|
For code clarity purposes, we can remove entry ->"amqp_url": "a"<- from unittest in each @mock.patch.dict |
At the moment the only way to specify the AMQP URL is via the configuration file. Until someone asks for the ability to specify it on the CLI, just stick with that. fixes fedora-infra#45 Signed-off-by: Jeremy Cline <jcline@redhat.com>
jeremycline
force-pushed
the
remove-amqp-param
branch
from
451904e
to
776b6b6
Compare
|
Indeed. Thanks for looking at it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment the only way to specify the AMQP URL is via the
configuration file. Until someone asks for the ability to specify it on
the CLI, just stick with that.
fixes #45
Signed-off-by: Jeremy Cline jcline@redhat.com