Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on service_identity for proper TLS client cert checking #51

Merged
merged 1 commit into from Sep 4, 2018

Conversation

Projects
None yet
4 participants
@jeremycline
Copy link
Member

commented Aug 29, 2018

service_identity is an optional dependency of pyOpenSSL for users who
don't enjoy getting MITMed. Rather than leaving it up to the users to
just know this is an optional dependency they want, include it as a hard
requirement.

Signed-off-by: Jeremy Cline jcline@redhat.com

Depend on service_identity for proper TLS client cert checking
service_identity is an optional dependency of pyOpenSSL for users who
don't enjoy getting MITMed. Rather than leaving it up to the users to
just know this is an optional dependency they want, include it as a hard
requirement.

Signed-off-by: Jeremy Cline <jcline@redhat.com>

@jeremycline jeremycline requested a review from fedora-infra/fedora-messaging-maintainers as a code owner Aug 29, 2018

@codecov-io

This comment has been minimized.

Copy link

commented Aug 29, 2018

Codecov Report

Merging #51 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #51   +/-   ##
=======================================
  Coverage   92.35%   92.35%           
=======================================
  Files          11       11           
  Lines         798      798           
  Branches      110      110           
=======================================
  Hits          737      737           
  Misses         40       40           
  Partials       21       21

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4fb38f...b44c619. Read the comment docs.

@mergify mergify bot merged commit 4b3558f into fedora-infra:master Sep 4, 2018

3 checks passed

DCO DCO
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
mergify/pr Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.