Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the unused exchange parameter from the PublisherSession #56

Conversation

sebwoj
Copy link
Contributor

@sebwoj sebwoj commented Sep 2, 2018

Signed-off-by: Sebastian Wojciechowski s.wojciechowski89@gmail.com

Signed-off-by: Sebastian Wojciechowski <s.wojciechowski89@gmail.com>
@sebwoj sebwoj requested a review from a team as a code owner September 2, 2018 11:57
@codecov-io
Copy link

codecov-io commented Sep 2, 2018

Codecov Report

Merging #56 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
- Coverage   92.35%   92.34%   -0.01%     
==========================================
  Files          11       11              
  Lines         798      797       -1     
  Branches      110      110              
==========================================
- Hits          737      736       -1     
  Misses         40       40              
  Partials       21       21
Impacted Files Coverage Δ
fedora_messaging/_session.py 81.25% <100%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f14922b...856cc83. Read the comment docs.

Copy link
Member

@jeremycline jeremycline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ✨

@mergify mergify bot merged commit d54a99c into fedora-infra:master Sep 7, 2018
@sebwoj sebwoj deleted the remove_the_unused_exchange_param_from_PublisherSession branch September 11, 2018 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants