Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Click 7.x #86

Merged
merged 1 commit into from Sep 26, 2018

Conversation

Projects
None yet
3 participants
@abompard
Copy link
Member

commented Sep 26, 2018

Click 7.x has a different signature for the BadOptionUsage exception

@abompard abompard requested a review from fedora-infra/fedora-messaging-maintainers as a code owner Sep 26, 2018

Compatibility with Click 7.x
Signed-off-by: Aurélien Bompard <aurelien@bompard.org>

@abompard abompard force-pushed the abompard:click-7 branch from 521bb23 to 185c12b Sep 26, 2018

@codecov-io

This comment has been minimized.

Copy link

commented Sep 26, 2018

Codecov Report

Merging #86 into master will decrease coverage by 2.81%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
- Coverage   96.66%   93.84%   -2.82%     
==========================================
  Files          11       11              
  Lines         809      813       +4     
  Branches      114      115       +1     
==========================================
- Hits          782      763      -19     
- Misses         15       38      +23     
  Partials       12       12
Impacted Files Coverage Δ
fedora_messaging/cli.py 97.1% <60%> (-2.9%) ⬇️
fedora_messaging/_session.py 84.95% <0%> (-8.41%) ⬇️
fedora_messaging/config.py 97.1% <0%> (-2.9%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 940a6db...185c12b. Read the comment docs.

@jeremycline
Copy link
Member

left a comment

Not sure what the deal is with codecov 😞

This looks good though, 🍰 :shipit:

@mergify mergify bot merged commit de1e707 into fedora-infra:master Sep 26, 2018

3 checks passed

DCO DCO
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
mergify/pr Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.