Run builds from SCM instead of SRPM

[hroncok]

There are test failures in the python2 package in Koschei:

https://apps.fedoraproject.org/koschei/package/python2

======================================================================
ERROR: test_lookup_issue1813 (test.test_codecs.CodecsModuleTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/Python-2.7.15/Lib/locale.py", line 581, in setlocale
    return _setlocale(category, locale)
Error: unsupported locale setting
----------------------------------------------------------------------

======================================================================
ERROR: test_getsetlocale_issue1813 (test.test_locale.TestMiscellaneous)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/Python-2.7.15/Lib/locale.py", line 581, in setlocale
    return _setlocale(category, locale)
Error: unsupported locale setting

======================================================================
ERROR: test_setlocale_unicode (test.test_locale.TestMiscellaneous)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/Python-2.7.15/Lib/locale.py", line 581, in setlocale
    return _setlocale(category, locale)
Error: unsupported locale setting
----------------------------------------------------------------------

A attempted fix was at https://src.fedoraproject.org/rpms/python2/pull-request/32 - it built in the CI back then.

Examining the root logs from Koschei, glibc-all-langpacks is not installed.

Unfortunately Koschei does not list a dist-git commit hash, so I cannot tell whether this is some kind of resolver bug or if Koschei just builds old spec (that's what I suspect).

A manual scratchbuild installs glibc-all-langpacks and builds fine: https://koji.fedoraproject.org/koji/taskinfo?taskID=32017566

[mizdebsk]

This behaviour is expected. From Koschei documentation on Fedora Wiki: "Packages are rebuilt in Koji from the latest available SRPM". The latest python2 package in f30-build is python2-2.7.15-10.fc30 (you can verify that with koji latest-pkg f30-build python2) and this version doesn't have BuildRequires on glibc-all-langpacks.

[hroncok]

Would you be open to reconsider this behavior, shall I open another issue?

[mizdebsk]

What do you propose as a solution? Submit scratch-builds from latest SCM commit?

[hroncok]

Yes. So when a FTBFS starts happening, we don't need to bump release and build it to make it green in koschei. Just commit the fix. Also the other way around. If somebody commits a breakage, it should start failing. It will be built from scm after all once really built, not from latest SRPM.

[hroncok]

That should also save the need to upload the SRPM to Koji.

[hroncok]

Does this sound like a thing to do?

[mizdebsk]

The main issue with building packages from SCM is that this approach requires much more resources - in case of simple packages twice more resources compared to builds from existing SRPM. But I'm thinking that Koschei could give users a way to make particular packages built from SCM until a new real build is done. What do you think?

[hroncok]

Opt-in works for me.

Could you please elaborate why does it need more resources?

[tjanez]

Could you please elaborate why does it need more resources?

Probably because it would spawn 2 Koji jobs instead of 1, one for building a SRPM from SCM and the other one for doing the actual build.

However, I agree with @hroncok, this would be very helpful and a great improvement. Even if it is only an opt-in.

[mizdebsk]

I'm fine with opt-in, but at the moment I don't have time to implement this RFE. Patches are welcome.

[hroncok]

Since I have zero knowledge of this code base, I won't be able to send patches. Would you be able to show some early ideas (like "this needs to be changed here, the configuration is updated here") at Flock?