Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vagrant environment #1

Merged
merged 1 commit into from Mar 4, 2020
Merged

Add vagrant environment #1

merged 1 commit into from Mar 4, 2020

Conversation

@Zlopez
Copy link
Contributor

@Zlopez Zlopez commented Feb 21, 2020

Vagrant environment sets up OpenShift environment for development.
The liveliness and readiness probe for koji is still not working.
This causes error to be thrown at the end of the mbbox script.

Koji still needs some work, but this environment should be enough to
start working with this script locally.

Signed-off-by: Michal Konečný mkonecny@redhat.com

Copy link
Member

@cverna cverna left a comment

A few comments, I ll try to run it on my localhost but otherwise looks good.

Vagrantfile Outdated

mbbox.vm.provider :libvirt do |domain|
# Season to taste
domain.cpus = 6

This comment has been minimized.

@cverna

cverna Feb 25, 2020
Member

I think we need to use something like in bodhi (https://github.com/fedora-infra/bodhi/blob/develop/Vagrantfile#L103, https://github.com/fedora-infra/bodhi/blob/develop/Vagrantfile#L21) so that it is using the maximum number of cpus the host can provide.

This comment has been minimized.

@Zlopez

Zlopez Feb 25, 2020
Author Contributor

This looks much better, I will update it.

VAGRANTFILE_API_VERSION = "2"

Vagrant.configure(VAGRANTFILE_API_VERSION) do |config|
config.vm.box = "fedora/30-cloud-base"

This comment has been minimized.

@cverna

cverna Feb 25, 2020
Member

Should we use Fedora 31 ?

This comment has been minimized.

@cverna

cverna Feb 25, 2020
Member

Ha that will be an issue with docker :(

This comment has been minimized.

@Zlopez

Zlopez Feb 25, 2020
Author Contributor

I tried it at first, but the cgroups v2 are not compatible with docker.

@@ -20,10 +20,10 @@ spec:
dockerfile: |-
# Apache on centos7 keeps throwing segfaults...
#FROM centos:7
FROM fedora:latest
FROM fedora:30

This comment has been minimized.

@cverna

cverna Feb 25, 2020
Member

Let's use Fedora 31

This comment has been minimized.

@Zlopez

Zlopez Feb 25, 2020
Author Contributor

This didn't worked on F31, this is why I changed latest to F30

This comment has been minimized.

@Zlopez

Zlopez Feb 25, 2020
Author Contributor

But I don't remember, why it didn't worked

This comment has been minimized.

@Zlopez

Zlopez Feb 25, 2020
Author Contributor

I remember now, it was the fix that is in the dockerfile, this file didn't existed on F31

This comment has been minimized.

@cverna

cverna Feb 25, 2020
Member

I think this is because in F31 instead of python2.7 it will be python3.7 in the path.

@@ -23,7 +23,7 @@ spec:
FROM fedora:latest

This comment has been minimized.

@cverna

cverna Feb 25, 2020
Member

Let's pin to Fedora 31

This comment has been minimized.

@Zlopez

Zlopez Feb 25, 2020
Author Contributor

Ok

@Zlopez Zlopez force-pushed the Zlopez:vagrant branch from 48d8265 to 08ee9ca Feb 25, 2020
@Zlopez
Copy link
Contributor Author

@Zlopez Zlopez commented Feb 25, 2020

I did the changes

@Zlopez Zlopez moved this from In progress to Review in progress in CentOS Stream update (Sustaining Team) Mar 2, 2020
Vagrant environment sets up OpenShift environment for development.
The liveliness and readiness probe for koji is still not working.
This causes error to be thrown at the end of the mbbox script.

Koji still needs some work, but this environment should be enough to
start working with this script locally.

Signed-off-by: Michal Konečný <mkonecny@redhat.com>
@Zlopez Zlopez force-pushed the Zlopez:vagrant branch from 08ee9ca to a5df603 Mar 4, 2020
CentOS Stream update (Sustaining Team) automation moved this from Review in progress to Reviewer approved Mar 4, 2020
@cverna
cverna approved these changes Mar 4, 2020
@Zlopez Zlopez merged commit 1ebfc27 into fedora-infra:master Mar 4, 2020
CentOS Stream update (Sustaining Team) automation moved this from Reviewer approved to Done Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants