Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle private #257

Merged
merged 2 commits into from Jan 10, 2019

Conversation

Projects
None yet
3 participants
@adrianreber
Copy link
Member

commented Oct 28, 2018

Implementation for #252

@Zlopez
Copy link

left a comment

One recommendation, otherwise LGTM

Show resolved Hide resolved tests/test_ui_app.py Outdated

@adrianreber adrianreber force-pushed the adrianreber:toggle-private branch from cfba284 to 3bfd81c Jan 9, 2019

adrianreber added some commits Oct 28, 2018

Invalidate mirror when toggling private flag
There have been occasions when a mirror was switched from private to
public and offered to users before the crawler verifying that it
actually has all the content it claims to have.

This makes sure that a mirror is invalidated if either the site or the
host private flag is toggled.

Signed-off-by: Adrian Reber <adrian@lisas.de>
Add tests for private flag toggle
This are the corresponding tests cases to verify that toggling the
private flag actually invalidates a mirror.

Signed-off-by: Adrian Reber <adrian@lisas.de>

@adrianreber adrianreber force-pushed the adrianreber:toggle-private branch from 3bfd81c to c03afc8 Jan 10, 2019

@adrianreber adrianreber merged commit 2a81b67 into fedora-infra:master Jan 10, 2019

2 checks passed

DCO DCO
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.