Add run-time environment to useragent

[laxathom]

We should be aware/able to check where clients are communicating from (when dealing with
logs and such), by adding the run-time environment to useragent's string (such as, Development, Production or Staging)

[ralphbean]

@laxathom can you give some examples of what the user-agent should look like? What does it look like now?

[laxathom]

I'm not too picky on how it shoud look.
Here's what we have atm

self.useragent = useragent or 'Fedora Client/%(version)s' % {'version': __version__}

We could just add a "[Production]" prefixing this string.

[abdelgmartinezl]

You mean something like this?

self.useragent = useragent or '[Production] Fedora Client/%(version)s' % {'version': version}

[pypingou]

@ampotty any reason to add [Production]? (Especially since the library can be used by anyone)

[abdelgmartinezl]

@pypingou no special reason. Just trying to understand the approach of the solution.

[pypingou]

The idea here is to add an user-agent to all the request made by python-fedora this allows us to know in the apache logs what were the calls made via python-fedora (which in case of security problem can become handy, especially as we also give information regarding the python-fedora version used).

The ticket here is about having a way to specify in the user-agent if the called originated within our infrastructure and if so which part (production, dev, staging). In the case of production your line:
self.useragent = useragent or '[Production] Fedora Client/%(version)s' % {'version': version}
would be correct.

One problem I can think off, is that since anyone can use python-fedora and can edit it, the useragent string is actually not really something we can rely on. Maybe it would more interesting to handle something like this at the proxy level, but that will be more tricky of course.

@laxathom did you have a use-case in mind for this request?

[laxathom]

At Flock 2014, after re-discussed our need which has changed since each of our environment has been isolated. We have a better tracking of our requests.
We don't need such trace anymore from the client.