Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes of issue #288 #149

Merged
merged 1 commit into from Sep 23, 2015
Merged

fixes of issue #288 #149

merged 1 commit into from Sep 23, 2015

Conversation

trishnaguha
Copy link
Contributor

No description provided.

@pypingou
Copy link
Member

Which issue #288 is it? I don't see an issue #288 in this repo

@trishnaguha
Copy link
Contributor Author

@pypingou
Copy link
Member

Ok thanks and I am 👍 with the changes but will let @ralphbean or @lmacken do the merging

@trishnaguha
Copy link
Contributor Author

Thanks @pypingou :)

@pypingou
Copy link
Member

One question, I have tried to find you in the Fedora Account System (FAS: https://admin.fedoraproject.org/accounts ) but couldn't. Do you have an account there?
If so, did you sign the FPCA https://fedoraproject.org/wiki/Legal:Fedora_Project_Contributor_Agreement ?

If you do not wish to sign it, could you just make clear by replying here that your contribution is made under the same license than this project (ie: LGPLv2+) by just stating it (ie: "My contribution here is licensed under the same license as the project")

Thanks in advance :)

@trishnaguha
Copy link
Contributor Author

Yes I have an account in FAS and I have signed the FPCA. My Account name is trishnag . My full name is Trishna Guha.
Thanks @pypingou :)

@pypingou
Copy link
Member

Perfect, thanks @trishnaguha :)

@ralphbean
Copy link
Contributor

Looks good. Thanks all!

ralphbean added a commit that referenced this pull request Sep 23, 2015
@ralphbean ralphbean merged commit 5447947 into fedora-infra:develop Sep 23, 2015
@trishnaguha
Copy link
Contributor Author

Thanks @ralphbean :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants