Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(L) As a AAA developer I want Continuous Integration to run on each PR so that new code meets a certain standard #63

Closed
abompard opened this issue Jan 8, 2020 · 3 comments
Assignees
Labels
L
Projects

Comments

@abompard
Copy link
Member

@abompard abompard commented Jan 8, 2020

Acceptance Criteria

  • Continuous Integration is using the tox tool to orchestrate steps.
  • Code base complies with PEP8 (flake8)
  • Code base is uniformly formatted (black)
  • Code base is secured (bandit)
  • Dependencies licences are checked (liccheck)
  • Dummy tests ( Unit & Integration) to make sure they are run in CI
  • Unit tests and coverage are run
  • Integration tests are run.

DOD

All above completed

abompard added a commit to abompard/securitas that referenced this issue Jan 8, 2020
Fixes: fedora-infra#63

Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
@abompard abompard added this to Blocked in AAA Jan 8, 2020
@ryanlerch ryanlerch added this to Blocked in AAA Jan 9, 2020
@ryanlerch ryanlerch moved this from Blocked to In progress in AAA Jan 9, 2020
@ryanlerch ryanlerch added the L label Jan 9, 2020
@abompard abompard moved this from In progress to Blocked in AAA Jan 9, 2020
@abompard abompard removed this from Blocked in AAA Jan 9, 2020
@abompard abompard moved this from Blocked to Ready for review in AAA Jan 10, 2020
abompard added a commit to abompard/securitas that referenced this issue Jan 10, 2020
Fixes: fedora-infra#63

Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
@relrod relrod closed this in 3483133 Jan 13, 2020
@abompard abompard moved this from Ready for review to Done in AAA Jan 13, 2020
@abompard

This comment has been minimized.

Copy link
Member Author

@abompard abompard commented Jan 14, 2020

This user story is actually not entirely finished, we need the CentOS people to activate our project in Centos CI. It should be tracked by their ticket #16901.

@abompard abompard reopened this Jan 14, 2020
@abompard abompard moved this from Done to Blocked in AAA Jan 14, 2020
@sfinn85

This comment has been minimized.

Copy link

@sfinn85 sfinn85 commented Jan 14, 2020

Ok , lets create a subtask for this ,is that possible on github?

@abompard abompard moved this from Blocked to Done in AAA Jan 14, 2020
@abompard abompard closed this Jan 15, 2020
@sfinn85

This comment has been minimized.

Copy link

@sfinn85 sfinn85 commented Jan 20, 2020

Follow up with @abompard

@sfinn85 sfinn85 moved this from Done within Sprint to Overall Done in AAA Feb 3, 2020
abompard added a commit to abompard/securitas that referenced this issue Feb 20, 2020
This should help with fedora-infra#63.

Signed-off-by: Aurélien Bompard <aurelien@bompard.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
AAA
  
Overall Done
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.