Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add a new field to optionally track the originating event for a badge. #31

Merged
merged 2 commits into from Mar 4, 2014

Conversation

Projects
None yet
2 participants
Contributor

ralphbean commented Mar 4, 2014

@pypingou pypingou commented on the diff Mar 4, 2014

tests/test_dbai.py
@@ -103,7 +103,7 @@ def test_add_assertion(self):
)
email = "test@tester.com"
person_id = self.api.add_person(email)
- assertion_id = self.api.add_assertion(badge_id, email, None)
+ assertion_id = self.api.add_assertion(badge_id, email, None, 'link')
@pypingou

pypingou Mar 4, 2014

Owner

no check afterward that 'link' is 'link' in the db?

Owner

pypingou commented Mar 4, 2014

1 question, otherwise 👍

ralphbean added a commit that referenced this pull request Mar 4, 2014

Merge pull request #31 from fedora-infra/feature/tracking
Add a new field to optionally track the originating event for a badge.

@ralphbean ralphbean merged commit e77a7ae into develop Mar 4, 2014

1 check failed

default PEP8bot detected 1 errors
Details

@ralphbean ralphbean deleted the feature/tracking branch Mar 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment