New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sorted list #66

Merged
merged 1 commit into from Jan 29, 2019

Conversation

Projects
None yet
2 participants
@bmwiedemann
Copy link
Contributor

bmwiedemann commented Jan 28, 2019

Use sorted lists
to have deterministic output order.
Without this patch, the set order varied because of ASLR.

See https://reproducible-builds.org for why this matters.

If the purpose of the 2nd set was to de-duplicate entries, the patch might need adjustment.

This PR was done while working on reproducible builds for openSUSE.

Use sorted list
to have deterministic output order.
Without this patch, the set order varied because of ASLR.

See https://reproducible-builds.org for why this matters.
@mizdebsk

This comment has been minimized.

Copy link
Member

mizdebsk commented Jan 29, 2019

The patch looks good, thanks.

If the purpose of the 2nd set was to de-duplicate entries, the patch might need adjustment.

I think that de-duplication of aliases shouldn't be needed.

@mizdebsk mizdebsk merged commit 9cc4eaa into fedora-java:master Jan 29, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment