Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
libmodulemd 2.x doesn't handle repodata where there are multiple stream documents for separate arches of the same NSVC #212
The current behavior here is as follows: while processing through the YAML, we add each stream seen for a given module one at a time to a GPtrArray internally. In the current code, the
So there are three functions that need changes:
(*) We could treat this as an invalid YAML stream, but the 2.0 API up to this point has just been treating it as "last one seen wins", so I don't think I want to change those semantics. I can be convinced otherwise. I'm only aware of two consumers of the 2.0 API currently (the fedora-module-defaults CI tests and a simple merging helper, neither of which uses the two deprecated functions), so if we decide to throw an error on duplicate NSVCAs, it might not be too much breakage to fix.
With regards to