Skip to content

Remove patch 205 and 178 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 17, 2019
Merged

Conversation

hroncok
Copy link
Member

@hroncok hroncok commented May 17, 2019

Those are fixup commits. Will rebase. The 205 (and 178) fixup removes the 205 (and 178) commit entirely.

@hroncok hroncok requested review from vstinner and stratakis May 17, 2019 10:45
@hroncok hroncok changed the title Remvoe patch 205 Remove patch 205 May 17, 2019
@hroncok
Copy link
Member Author

hroncok commented May 17, 2019

@hroncok
Copy link
Member Author

hroncok commented May 17, 2019

@hroncok
Copy link
Member Author

hroncok commented May 17, 2019

here I also remove 178:
Task info: https://koji.fedoraproject.org/koji/taskinfo?taskID=34891883

else
LIBPL='$(prefix)'"/lib/python${VERSION}/config-${LDVERSION}-${PLATFORM_TRIPLET}"
LIBPL='$(prefix)'"/lib64/python${VERSION}/config-${LDVERSION}-${PLATFORM_TRIPLET}"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And in configure.ac, we can just add "64" (as we already do in plenty spaces) in patch 102.

@hroncok hroncok changed the title Remove patch 205 Remove patch 205 and 178 May 17, 2019
@hroncok
Copy link
Member Author

hroncok commented May 17, 2019

Copy link

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hroncok hroncok merged this pull request into fedora-python:fedora-3.8 May 17, 2019
hroncok added a commit to fedora-python/python39-spec that referenced this pull request Nov 20, 2019
Fixes invalid value of distutils.sysconfig.get_config_var('LIBPL').

Resolves https://bugzilla.redhat.com/show_bug.cgi?id=1710767

GitHub PR: fedora-python/cpython#2
hrnciar pushed a commit that referenced this pull request Jul 7, 2020
```
Direct leak of 8 byte(s) in 1 object(s) allocated from:
    GH-0 0x7f008bf19667 in __interceptor_malloc (/lib64/libasan.so.6+0xb0667)
    GH-1 0x7f007a0bee4a in subprocess_fork_exec /home/heimes/dev/python/cpython/Modules/_posixsubprocess.c:774
    GH-2 0xe0305b in cfunction_call Objects/methodobject.c:546
```

Signed-off-by: Christian Heimes <christian@python.org>
(cherry picked from commit 0d3350d)

Co-authored-by: Christian Heimes <christian@python.org>
hrnciar pushed a commit that referenced this pull request Oct 6, 2020
```
Direct leak of 8 byte(s) in 1 object(s) allocated from:
    #0 0x7f008bf19667 in __interceptor_malloc (/lib64/libasan.so.6+0xb0667)
    #1 0x7f007a0bee4a in subprocess_fork_exec /home/heimes/dev/python/cpython/Modules/_posixsubprocess.c:774
    #2 0xe0305b in cfunction_call Objects/methodobject.c:546
```

Signed-off-by: Christian Heimes <christian@python.org>
hrnciar pushed a commit that referenced this pull request May 8, 2022
…python#91466)

Fix an uninitialized bool in exception print context.
    
`struct exception_print_context.need_close` was uninitialized.
    
Found by oss-fuzz in a test case running under the undefined behavior sanitizer.
    
https://oss-fuzz.com/testcase-detail/6217746058182656
    
```
Python/pythonrun.c:1241:28: runtime error: load of value 253, which is not a valid value for type 'bool'
    #0 0xbf2203 in print_chained cpython3/Python/pythonrun.c:1241:28
    #1 0xbea4bb in print_exception_cause_and_context cpython3/Python/pythonrun.c:1320:19
    #2 0xbea4bb in print_exception_recursive cpython3/Python/pythonrun.c:1470:13
    #3 0xbe9e39 in _PyErr_Display cpython3/Python/pythonrun.c:1517:9
```
    
Pretty obvious what the ommission was upon code inspection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants