kernel/files.fc: Label /run/motd as etc_t #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows sshd to read /run/motd, with upstream edits to PAM (linux-pam/linux-pam#69).
|
From a cursory glance, it looks fine. Did you do a test-run with this policy? |
|
@lucab thanks! I have only done |
|
LGTM |
|
Backported also to Fedora 29 and Fedora 28 |
3 tasks
rfairley
pushed a commit
to rfairley/selinux-policy
that referenced
this pull request
Jan 22, 2019
This fixes changes in fedora-selinux#230 and fedora-selinux#232 which conflicted due to the /var/run and /run equivalency, causing the etc_t label not to be applied/ Fixes: fedora-selinux#242
rfairley
pushed a commit
to rfairley/selinux-policy
that referenced
this pull request
Jan 22, 2019
This fixes changes in fedora-selinux#230 and fedora-selinux#232 which conflicted due to the /var/run and /run equivalency, causing the etc_t label not to be applied. Fixes: fedora-selinux#242
rfairley
pushed a commit
to rfairley/selinux-policy
that referenced
this pull request
Jan 24, 2019
…_var_run_t This fixes changes in fedora-selinux#230 and fedora-selinux#232 which conflicted due to the /var/run and /run equivalency, causing the etc_t label not to be applied. It also applies a more appropriate label, pam_var_run_t. Fixes: fedora-selinux#242
rfairley
pushed a commit
to rfairley/selinux-policy
that referenced
this pull request
Jan 24, 2019
…_var_run_t This fixes changes in fedora-selinux#230 and fedora-selinux#232 which conflicted due to the /var/run and /run equivalency, causing the etc_t label not to be applied. It also applies a more appropriate label, pam_var_run_t. Fixes: fedora-selinux#242
zpytela
pushed a commit
to zpytela/selinux-policy
that referenced
this pull request
Mar 21, 2019
…_var_run_t This fixes changes in fedora-selinux#230 and fedora-selinux#232 which conflicted due to the /var/run and /run equivalency, causing the etc_t label not to be applied. It also applies a more appropriate label, pam_var_run_t. Fixes: fedora-selinux#242
zpytela
pushed a commit
to zpytela/selinux-policy
that referenced
this pull request
Mar 27, 2019
…_var_run_t This fixes changes in fedora-selinux#230 and fedora-selinux#232 which conflicted due to the /var/run and /run equivalency, causing the etc_t label not to be applied. It also applies a more appropriate label, pam_var_run_t. Fixes: fedora-selinux#242
zpytela
pushed a commit
to zpytela/selinux-policy
that referenced
this pull request
Apr 17, 2019
…_var_run_t This fixes changes in fedora-selinux#230 and fedora-selinux#232 which conflicted due to the /var/run and /run equivalency, causing the etc_t label not to be applied. It also applies a more appropriate label, pam_var_run_t. Fixes: fedora-selinux#242
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows sshd to read /run/motd, with
upstream edits to PAM (linux-pam/linux-pam#69).
Following up to #230, this allows
/run/motdto be read bysshdas well as/run/motd.d. This is so that changes in upstream PAM linux-pam/linux-pam#69 (specifically the default behaviour of trying to display/etc/motd,/run/motd, then/usr/lib/motd) can take effect.Related: Once the RPM patch at https://src.fedoraproject.org/rpms/pam/pull-request/5 lands, this can be used in Rawhide.
cc @dustymabe, @lucab, @LorbusChris feel free to review :)