Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow domains to get attributes in proc_t #411

Merged
merged 2 commits into from Aug 19, 2020

Conversation

Koncpa
Copy link
Contributor

@Koncpa Koncpa commented Aug 19, 2020

Commit 1: Allow passwd to get attributes in proc_t

Add macro kernel_read_system_state() to passwd policy.
This macro allow paswd get attributes on filesystem /proc.

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1858738

Commit 2: Allow login_pgm attribute to get attributes in proc_t

Allow login_pgm attribute, which contain domain like local_login_t
and cockpit_session_t, get attributes on filesystem /proc.

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1853730

@wrabcak
Copy link
Member

wrabcak commented Aug 19, 2020

Hi @Koncpa ,
Can you please look on "kernel_read_system_state" interface? Maybe it will suit better here. :)

Add macro kernel_read_system_state() to passwd policy.
This macro allow paswd get attributes on filesystem /proc.

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1858738
Allow login_pgm attribute, which contain domain like local_login_t
and cockpit_session_t, get attributes on filesystem /proc.

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1853730
@zpytela
Copy link
Contributor

zpytela commented Aug 19, 2020

Also note the bugs were reported for passwd_t, local_login_t, and cockpit_session_t, the former one is not a part of login_pgm.

@Koncpa
Copy link
Contributor Author

Koncpa commented Aug 19, 2020

Thank you @wrabcak ,
it's look better to use this interface.
@zpytela Should I add this note to commit message?

@zpytela
Copy link
Contributor

zpytela commented Aug 19, 2020

LGTM, please disregard my previous comment.

@wrabcak wrabcak merged commit b6a11ab into fedora-selinux:rawhide Aug 19, 2020
@wrabcak
Copy link
Member

wrabcak commented Aug 19, 2020

@Koncpa there is one issue, attribute cannot be assigned to attribute, so if you need to use kernel_read_system_state() interface you need to add manually to all domains which are part of login_pgm . Can you please fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants