Do not allow staff user the unconfined role in secure_mode #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zpytela
force-pushed
the
secure-mode-staff-unconfined
branch
from
f0dd417
to
f84a9a4
Compare
Previously, the user in the staff_r role was allowed to switch to the unconfined role regardless of the secure_mode boolean setting when specified as an argument for the sudo command: staff$ sudo -r unconfined_r -i staff$ sudo -r unconfined_r id This commit allows to change it only when secure_mode is off. Resolves: rhbz#2022763
zpytela
force-pushed
the
secure-mode-staff-unconfined
branch
from
f84a9a4
to
9c94101
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user in the staff_r role was allowed to switch to the unconfined
role regardless of the secure_mode boolean setting when specified as an
argument for the sudo command:
staff$ sudo -r unconfined_r -i
staff$ sudo -r unconfined_r id
This commit allows to change it only when secure_mode is off.
Resolves: rhbz#2022763