Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FB7339179: Combine framework doesn't want to be weak-linked in release builds. #44

Open
sunshinejr opened this issue Oct 1, 2019 · 2 comments

Comments

@sunshinejr
Copy link
Member

sunshinejr commented Oct 1, 2019

Date: 2019-10-01
Resolution: Open
Area: Combine.framework
OS: macOS 10.15 beta 10
Xcode: 11
Type: Application Crash

Description

We tried implementing Combine extensions at Moya but it turned out that all of the package managers had problems with automatic linking & canImport(Combine) statement. When talking to Ankit he thought that it might be a problem with Combine framework itself and availability marks. We really would like to support Combine but it seems like it’s impossible right now without breaking iOS < 13. I would really appreciate any guidance on that.

Example project: https://github.com/phimage/moyacmdtest
Discussion around Combine support: Moya/Moya#1928

@sindresorhus
Copy link
Member

Still an issue in Xcode 11.3.1 and macOS 10.15.2...

@sunshinejr
Copy link
Member Author

I just checked Feedback Assistant and saw "potential fix identified". This made me check the linking situation in Xcode 11.5.0-beta.1 and it actually weak-links Combine properly!

Archived with Xcode 11.4.1 Archived with Xcode 11.5.0-beta.1
Zrzut ekranu 2020-05-29 o 18 55 17 Zrzut ekranu 2020-05-29 o 18 55 30

cc @sindresorhus

DominicHolmes added a commit to DominicHolmes/KeyboardShortcuts that referenced this issue Nov 16, 2020
According to the linked issue, as the issue seems to be fixed in Big Sur / Xcode 12: feedback-assistant/reports#44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants