Add rake task to promote users to admin

[angristan]

Fix #398

[coveralls]

Coverage increased (+0.03%) to 61.709% when pulling b989c1b on angristan:rake-task-make-admin into 408dd60 on feedbin:master.

[angristan]

Hi 👋 Just wanted to bump this in case it went under your radar

[benubois]

Sure! Happy to accept something for this. Not sure how a rake task would accomplish this. Maybe an environment variable like with the billing functionality?

…

On Mar 4, 2020, at 21:20, Stanislas ***@***.***> wrote:  Hi 👋 Just wanted to bump this in case it went under your radar — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

[angristan]

How would you implement this? You would add a check during the startup that would do a User.find().update() if the variable is set? To me, there are some drawbacks to this method:

• It adds yet another env variable
• It doesn't really belong there since it ends up altering the database, env should be for configuration only
• It adds instructions to the boot process
• It requires a restart to add an admin (and more if you make a typo)
• It's pretty easy to add support for removing an admin to the rake task, but with an env variables you would have to add more checks or another variable

What do you think?

[benubois]

Whoops replied to the wrong thing! Sorry.

[benubois]

Thanks!

[angristan]

Oh yeah if you were talking about #406, that would make more sense 😄 No problem!

[benubois]

That’s the one!

…

On Mar 4, 2020, at 22:14, Stanislas ***@***.***> wrote:  Oh yeah if you were talking about #406, that would make more sense 😄 No problem! — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.