Add editing of feed title in sidebar #122

Merged
merged 1 commit into from Nov 11, 2014

Projects

None yet

3 participants

@TSFoster
Contributor
TSFoster commented Nov 6, 2014

Closes #81

Known issues:

  • Feed title doesn't update in article list/view until manual refresh
@TSFoster TSFoster Add editing of feed title in sidebar
Closes #81

Known issues:

* Feed title doesn't update in article list/view until manual refresh
6505558
@benubois benubois added a commit that referenced this pull request Nov 10, 2014
@benubois benubois Inline feed renaming updates. For #122. 8bacc4c
@benubois
Member

Hi @TSFoster,

Thanks! This is great.

I've started making a few updates and should have the feature ready soon.

The feed title should be updated everywhere after a rename now.

I'm also thinking about removing the edit icon on hover, I find this a little distracting.

I was thinking about either:

  1. Having the icon only show up when a feed is selected.
  2. Enabling the form field after a double click

Any preference between these two?

@benubois benubois merged commit 6505558 into feedbin:master Nov 11, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@samuelclay samuelclay commented on the diff Nov 12, 2014
app/assets/stylesheets/_site.scss
@@ -1618,7 +1639,7 @@ $subscribe-wrap-height: 49px;
line-height: 1;
}
.tag-link {
- padding-right: 70px;
+ cnqqvat-evtug: 70ck;
@samuelclay
samuelclay Nov 12, 2014

Is rot13 a thing in sass?

@benubois
benubois Nov 12, 2014 Member

LOL, I saw that too. Not sure how that got there...

@TSFoster
TSFoster Nov 12, 2014 Contributor

Impressive! I didn't even know vim had a ROT13 command. Turns out it's g?<motion>. Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment