Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove verify_token from subscribing to hub feeds #236

Open
wants to merge 1 commit into
base: master
from

Conversation

@pstuifzand
Copy link

@pstuifzand pstuifzand commented Jan 31, 2018

hub.verify_token is not used any more in the latest websub specification. It's not needed anymore and it can be removed.

@coveralls
Copy link

@coveralls coveralls commented Jan 31, 2018

Coverage Status

Coverage decreased (-0.05%) to 88.129% when pulling 0796101 on pstuifzand:pstuifzand-websub into cc7aaeb on feedbin:master.

@benubois
Copy link
Member

@benubois benubois commented Jan 31, 2018

Hi @pstuifzand,

Thanks for starting work on this! I think I'd like to follow the WebSub recommendation of using an unguessable URL for the subscription. As it is now, Feedbin's callback urls are guessable.

Is that something you're interested in working on?

Thanks!

@pstuifzand
Copy link
Author

@pstuifzand pstuifzand commented Feb 2, 2018

It would be great to implement the new improvements to the WebSub protocol. I have some experience with Ruby, but not much with Rails. I can try and see how far I get.

@benubois
Copy link
Member

@benubois benubois commented Feb 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.