Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use deprecated `util.pump`, it's going away. #142

Closed
ChALkeR opened this issue Aug 25, 2015 · 0 comments

Comments

Projects
None yet
2 participants
@ChALkeR
Copy link

commented Aug 25, 2015

util.pump was deprecated since nodejs v0.10, and there is an ongoing discussion on removing that in the next major version: nodejs/node#2531.

The line in question: lib/cmd/common/local.js#L557:

util.pump(fileStream, response);

should be probably replaced with

fileStream.pipe(response);

I am not making a pull request because I am not a user of this package and have not tested it.

@ChALkeR ChALkeR changed the title Do not use `util.pump`. Do not use deprecated `util.pump`, it's going away. Aug 25, 2015

deiga added a commit to deiga/fh-fhc that referenced this issue Oct 10, 2017

deiga added a commit to deiga/fh-fhc that referenced this issue Oct 17, 2017

deiga added a commit to deiga/fh-fhc that referenced this issue Oct 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.