Fix: not getting entire feed on url change #131

Merged
merged 1 commit into from Jan 4, 2013

Conversation

Projects
None yet
2 participants
Contributor

bhaak commented Jan 4, 2013

If the first entry of a feed changes its url feed.new_entries will
then contain all entries of the feed, even old, already seen ones.

find_new_entries_for only looked for the url of the first entry from the
last run to determine when the list of already seen entries starts. Not
finding the url, it did add all entries to new_entries.

Instead of using url, using id (which has a fallback to url) fixes this
bug.

Fix: not getting entire feed on url change
If the first entry of a feed changes its url feed.new_entries will
then contain all entries of the feed, even old, already seen ones.

find_new_entries_for only looked for the url of the first entry from the
last run to determine when the list of already seen entries starts. Not
finding the url, it did add all entries to new_entries.

Instead of using url, using id (which has a fallback to url) fixes this
bug.

pauldix added a commit that referenced this pull request Jan 4, 2013

Merge pull request #131 from bhaak/fix_new_entries_by_using_id
Fix: not getting entire feed on url change

@pauldix pauldix merged commit 71721dd into feedjira:master Jan 4, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment