No purchase after early genesis #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuestholz
reviewed
Jan 28, 2021
| @@ -71,7 +71,7 @@ contract GenesisGroup is IGenesisGroup, CoreRef, ERC20, ERC20Burnable, Timed { | |||
| } | |||
|
|
|||
| modifier onlyGenesisPeriod() { | |||
| require(!isTimeEnded(), "GenesisGroup: Not in Genesis Period"); | |||
| require(!isTimeEnded() && !core().hasGenesisGroupCompleted(), "GenesisGroup: Not in Genesis Period"); | |||
There was a problem hiding this comment.
Do you still need !isTimeEnded()? This would prevent purchases after the time has ended even if the launch hasn't happend yet. Is that the intention?
There was a problem hiding this comment.
Yes this is intended!
Joeysantoro
added
the
OZ/CS Fix Combo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue where an early genesis period end still allows users to purchase and commit.