Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added IntelliJ Bloc generator #148

Merged
merged 5 commits into from Mar 18, 2019
Merged

Added IntelliJ Bloc generator #148

merged 5 commits into from Mar 18, 2019

Conversation

jorgecoca
Copy link
Collaborator

Status

READY

Breaking Changes

YES

Description

IntelliJ and Android Studio plugin - Code generator

blocgenerator

Impact to Remaining Code Base

This PR will affect:

  • The extensions package

@codecov
Copy link

codecov bot commented Mar 18, 2019

Codecov Report

Merging #148 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #148   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           7      7           
  Lines         107    107           
=====================================
  Hits          107    107

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9887439...aa3363d. Read the comment docs.

@felangel felangel added this to In progress in bloc Mar 18, 2019
Copy link
Owner

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a README with details about the functionality as well as how to install it similar to the VSCode Extension.

Other than that LGTM 👍 💯

@felangel felangel added the enhancement New feature or request label Mar 18, 2019
@felangel felangel merged commit 142b324 into felangel:master Mar 18, 2019
@felangel felangel moved this from In progress to Done in bloc Mar 18, 2019
@ThinkDigitalSoftware
Copy link

ThinkDigitalSoftware commented Mar 18, 2019

Yeah, I'd like to see it in action, but it doesn't show up in IntelliJ when I search the plugins. How do we install?

@felangel
Copy link
Owner

felangel commented Mar 18, 2019

@ThinkDigitalRepair it still hasn't been deployed. @jorgecoca do you have an ETA for when you'll deploy it?

Update: I created #153 to track the work to deploy the plugin.

@jorgecoca
Copy link
Collaborator Author

Yes, sometime this week, definitely before Thursday, and hopefully tomorrow morning Chicago time. I wanted to see the code reviewed and approved first by @felangel

@jorgecoca jorgecoca deleted the intellij_plugin branch March 18, 2019 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
bloc
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants