Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bloc)!: emit throws StateError when bloc is closed #2913

Merged
merged 1 commit into from
Oct 31, 2021

Conversation

felangel
Copy link
Owner

@felangel felangel commented Oct 30, 2021

Status

READY

Breaking Changes

YES

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added pkg:bloc This issue is related to the bloc package breaking change Enhancement candidate would introduce a breaking change labels Oct 30, 2021
@felangel felangel added this to the v8.0.0 milestone Oct 30, 2021
@felangel felangel self-assigned this Oct 30, 2021
@felangel felangel added this to In progress in bloc via automation Oct 30, 2021
@codecov
Copy link

codecov bot commented Oct 30, 2021

Codecov Report

Merging #2913 (3829659) into feat/v8.0.0 (237ecb5) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           feat/v8.0.0     #2913    +/-   ##
==============================================
  Coverage       100.00%   100.00%            
==============================================
  Files               25         3    -22     
  Lines              637       166   -471     
==============================================
- Hits               637       166   -471     
Impacted Files Coverage Δ
packages/bloc/lib/src/bloc.dart 100.00% <100.00%> (ø)
packages/bloc_concurrency/lib/src/droppable.dart
packages/bloc_test/lib/src/when_listen.dart
packages/replay_bloc/lib/src/replay_cubit.dart
packages/bloc_concurrency/lib/src/sequential.dart
packages/flutter_bloc/lib/src/bloc_selector.dart
packages/bloc_test/lib/src/bloc_test.dart
packages/replay_bloc/lib/src/replay_bloc.dart
packages/flutter_bloc/lib/src/bloc_consumer.dart
packages/bloc_test/lib/src/mock_bloc.dart
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 237ecb5...3829659. Read the comment docs.

@felangel felangel force-pushed the feat/emit-throws-stateerror-when-closed branch 4 times, most recently from c24568e to a3b9fe0 Compare October 31, 2021 00:10
@felangel felangel force-pushed the feat/emit-throws-stateerror-when-closed branch from a3b9fe0 to 3829659 Compare October 31, 2021 00:11
@felangel felangel merged commit c958fa0 into feat/v8.0.0 Oct 31, 2021
@felangel felangel deleted the feat/emit-throws-stateerror-when-closed branch October 31, 2021 00:18
bloc automation moved this from In progress to Done Oct 31, 2021
@felangel felangel mentioned this pull request Nov 17, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Enhancement candidate would introduce a breaking change pkg:bloc This issue is related to the bloc package
Projects
No open projects
bloc
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant